Refactor NMODL integration. #3150
Open
+33
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3150 +/- ##
=======================================
Coverage 67.11% 67.11%
=======================================
Files 571 571
Lines 111318 111318
=======================================
Hits 74714 74714
Misses 36604 36604 ☔ View full report in Codecov by Sentry. |
|
✔️ bc472bb -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/refactor-nmodl-cmake
branch
from
bc472bb
to
ae60fb1
Compare
matz-e
reviewed
Oct 31, 2024
|
✔️ ae60fb1 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
matz-e
approved these changes
Oct 31, 2024
1uc
force-pushed
the
1uc/refactor-nmodl-cmake
branch
from
ae60fb1
to
139f7da
Compare
|
✔️ 139f7da -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
matz-e
reviewed
Oct 31, 2024
|
|
✔️ 119e918 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the logic for including NMODL to the top-level
CMakeLists.txt. Next it removes the ability to "find" NMODL. Instead it will unconditionally use the version found in the submodule.Developers can inject a custom version by either:
nrnivmodl -nmodl $(which nmodl).